Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleanup based on #142
changes:
"@types/node": "^16.11.68"
because the vscode engine we are targeting (^1.77.0
) uses node16.14.2
. The closest version to match it with@types/node
is16.11.x
. This should keep the extension code to whatever API is available in that version."@types/vscode": "^1.77.0",
should match our targeted vscode engineapps/vscode-extension
, its still part of the rootpackage.json
@types/eslint__js
mocha
,glob
,path-browserify
from root package, as they are part from specific packages that use them.node >= 20
to `engines field in root package.json, before the merge this was present. This should help in indicating node >= 20 is needed to build & develop the project without issuesglobals
package to make it stop complaining.nodeDepsPlugin
, aspath
is not actually used, thus no need to resolve to a polyfill@yoavbls I tried to keep this minimal to only update non breaking stuff, but I'm not sure about how to structure packages in a mono repo.
Right now the root has:
And each package itself has devDepencies to build itself and runtime dependencies that it uses at runtime.