Downloads dir: Don't change permissions#285
Merged
Conversation
iLLiCiTiT
added
the
type: enhancement
BigRoy
approved these changes
Feb 19, 2026
Contributor
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Description + code changes make sense. Didn't test.
|
|
||
| def __init__(self, cleanup_on_fail: bool, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| super().__init__(*args, **kwargs, change_permissions=False) |
Contributor
There was a problem hiding this comment.
Should we still allow via kwargs?
Suggested change
| super().__init__(*args, **kwargs, change_permissions=False) | |
| # Use default False for `change_permissions` | |
| change_permissions = kwargs.pop("change_permissions", False) | |
| super().__init__(*args, **kwargs, change_permissions=change_permissions) |
Member
Author
There was a problem hiding this comment.
We don't have use-case for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Avoid change of permissions for installer download dir.
Additional info
Download directory for installer is user's download dir, we should not recursivelly change permissions there.
Testing notes: