[ASAP-1359][ASAP-1365] display associated articles and statuses for aims on project detail page#4970
Open
AimeurAmin wants to merge 11 commits intomasterfrom
Open
Conversation
AimeurAmin
commented
Mar 30, 2026
Comment on lines
126
to
127
| {}, | ||
| expect.any(Object), | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
In commit 714b0c0 ("removes redundant loggedInUser from opensearch search method"), loggedInUser was removed from most test assertions — but the "should handle empty request body" test case was missed. Its assertion still had expect.any(Object) as the third argument while all the other tests in the same file had that line removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4970 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 1258 1260 +2
Lines 28600 28640 +40
Branches 9282 9293 +11
=======================================
+ Hits 28494 28534 +40
Misses 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…opensearchProvider access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASAP-1359
ASAP-1365
Notes:
loggedInUserwas being passed all the way from the route → controller → data provider, but the auth check (if(!loggedInUser) throw Boom.forbidden())already lives in opensearch.route.ts before the controller is ever called. The guard in the data provider was therefore unreachable in practice — any unauthenticated request would have been rejected at the route level first. Removing it from the data provider also unblocks internal server-side callers (like the project data provider) from using search without needing a user in scope.