Skip to content

[ASAP-1359][ASAP-1365] display associated articles and statuses for aims on project detail page#4970

Open
AimeurAmin wants to merge 11 commits intomasterfrom
ASAP-1359-Display-Associated-Articles-for-Aim-on-Project-Detail-page
Open

[ASAP-1359][ASAP-1365] display associated articles and statuses for aims on project detail page#4970
AimeurAmin wants to merge 11 commits intomasterfrom
ASAP-1359-Display-Associated-Articles-for-Aim-on-Project-Detail-page

Conversation

@AimeurAmin
Copy link
Copy Markdown
Collaborator

@AimeurAmin AimeurAmin commented Mar 30, 2026

ASAP-1359
ASAP-1365

Notes:

  • Aims are now fetched from Opensearch instead of Contentful as discussed in previous standups
  • In commit 714b0c0 ("removes redundant loggedInUser from opensearch search method"):
    loggedInUser was being passed all the way from the route → controller → data provider, but the auth check (if (!loggedInUser) throw Boom.forbidden()) already lives in opensearch.route.ts before the controller is ever called. The guard in the data provider was therefore unreachable in practice — any unauthenticated request would have been rejected at the route level first. Removing it from the data provider also unblocks internal server-side callers (like the project data provider) from using search without needing a user in scope.

Comment on lines 126 to 127
{},
expect.any(Object),
);
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit 714b0c0 ("removes redundant loggedInUser from opensearch search method"), loggedInUser was removed from most test assertions — but the "should handle empty request body" test case was missed. Its assertion still had expect.any(Object) as the third argument while all the other tests in the same file had that line removed.

@AimeurAmin AimeurAmin changed the title Asap 1359 display associated articles and statuses for aims on project detail page [ASAP-1359][ASAP-1365] display associated articles and statuses for aims on project detail page Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (f8387a9) to head (95f4d94).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4970   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        1258     1260    +2     
  Lines       28600    28640   +40     
  Branches     9282     9293   +11     
=======================================
+ Hits        28494    28534   +40     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant