-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
feat: generic types for DI classes #20354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20354 +/- ##
=========================================
Coverage 64.85% 64.85%
Complexity 11445 11445
=========================================
Files 431 431
Lines 37208 37208
=========================================
Hits 24132 24132
Misses 13076 13076 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xepozz
suggested changes
Apr 22, 2025
xepozz
approved these changes
Apr 22, 2025
terabytesoftw
approved these changes
Apr 22, 2025
Arhell
approved these changes
Apr 23, 2025
samdark
approved these changes
Apr 24, 2025
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I was trying to increase PHPStan level in a Yii2 based project and came across some errors due to Instance and Container classes. When I checked the repository I saw that Container class was recently updated but it seems to have some errors. I would like to fix them. I also want to add some new annotations to Instance::ensure
Example
Before changes
After changes