Update BaseStringHelper.php

[spzgy]

Exception 'TypeError' with message 'count(): Argument #1 ($value) must be of type Countable|array, bool given'

Q	A
Is bugfix?	✔️/❌
New feature?	✔️/❌
Breaks BC?	✔️/❌
Fixed issues

[what-the-diff]

PR Summary

• Enhancement to the Word Counting Method
  In the base string helper module, a modification has been introduced to the method responsible for counting words. A new variable has been incorporated to capture the result of a function that splits the input text. After this split operation, there's now an extra layer of verification to ensure the result is valid before proceeding to count the words, thus avoiding potential errors or inaccuracies in the word count.

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.02%. Comparing base (b46e267) to head (b63ba54).
⚠️ Report is 256 commits behind head on master.

Files with missing lines	Patch %	Lines
framework/helpers/BaseStringHelper.php	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #20099   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files         445      445           
  Lines       43889    43892    +3     
=======================================
+ Hits        21077    21079    +2     
- Misses      22812    22813    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[samdark]

Looks alright 👍 Would you please add a unit test and a line for CHANGELOG?

[rob006]

AFAIK preg_split() returns false only if you pass invalid input or regex. In countWords() regex is hardcoded, so input must be a problem - for what value (and what scenario) you get this error?

[Webkadabra]

Please, reject and close this PR. Author has no idea what he is doing. The variable he is trying to run count() on is a string. If anything, a string type could be added, not a count() on a STRING.

Why end it on the array then? What if it is not an arra,y and not a string? What if I have some words in binary? Please, looks for troubles elsewhere, REJECT THIS PR.

[Webkadabra]

Looks alright 👍 Would you please add a unit test and a line for CHANGELOG?

this is nonsense PR, seriously

[Webkadabra]

@spzgy you're adding array methods to a STRING HELPER class. Do you keep your milk out on a porch, and your cat is inside a freezer? What are you doing, my man?

[schmunk42]

AFAIK preg_split() returns false only if you pass invalid input or regex. In countWords() regex is hardcoded, so input must be a problem - for what value (and what scenario) you get this error?

@spzgy As @rob006 mentioned: Please provide an example for the error you get and which PHP version are you using.

Related: https://stackoverflow.com/a/59335626