-
-
Notifications
You must be signed in to change notification settings - Fork 18
Trim decimals #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samdark
wants to merge
23
commits into
2.x
Choose a base branch
from
trim-decimals
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−5
Open
Trim decimals #156
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
be2294f
Trim decimals
samdark cad1804
Add CHANGELOG number
samdark 2372b81
Update tests/NumericHelperTest.php
samdark 8cc129a
Rename data provider to follow naming convention (#158)
Copilot b46f55b
Add missing use function imports in NumericHelper (#157)
Copilot 408811e
Update src/NumericHelper.php
samdark 85223ac
Return null for empty string
samdark c1afac0
Rewrite algorithm
samdark 76b057e
Add benchmark
samdark 079d40b
Revert implementation
samdark 4576748
Choose more readable code
samdark aa39acb
Update src/NumericHelper.php
samdark da589d5
Handle edge cases
samdark 3a4fcf6
Adjust tests and code
samdark 3ce77f6
Add edge case test
samdark db2011c
Handle edge case
samdark 591ffc1
Fix edge case
samdark 284d16d
Remove phpunit results cache
samdark 32d05ad
Accept numeric strings only
samdark ba96511
Optimize code
samdark 9e34d19
Remove unnecessary file, describe trim()
samdark f8d9494
Mention method in readme
samdark e5c2d93
Add @vjik to authors
samdark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.