fix: use PkgConfig::ZMQ with PUBLIC linkage and override macOS dynami… #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ZMQ linking issues that cause
ImportError: symbol not found '_zmq_close'during editable installs.Problem
ImportErrorfor ZMQ symbols-undefined dynamic_lookupwhich defers symbol resolutionRoot Cause
IMPORTED_TARGETinpkg_check_modules-undefined dynamic_lookupflag deferred symbol resolutionSolution
pkg_check_modules IMPORTED_TARGETto create proper CMake targetsPKG_CONFIG_PATHto prioritize ARM64 Homebrew on Apple Silicon-undefined dynamic_lookupto force symbol resolution at build timeTesting
Related
This fix is required for LEANN PR facebookresearch#150 (metadata output feature) and PR #152 (Ollama batching optimization).