Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new get_multiple* tools to complement existing search functionality in the Yeti MCP server. The tools allow retrieving multiple objects by name rather than searching by partial matches.
- Adds get_multiple_tags, get_multiple_entities, get_multiple_indicators, and get_multiple_dfiq tools
- Updates test file patch paths from src.server.tools to src.yeti_mcp.tools
- Adds VS Code MCP configuration file for development setup
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/yeti_mcp/tools.py | Implements four new get_multiple* tools and one search_tags tool |
| tests/test_tools.py | Updates import paths and adds tests for three new get_multiple* tools |
| .vscode/mcp.json | Adds VS Code MCP server configuration for development |
Comments suppressed due to low confidence (1)
tests/test_tools.py:118
- Missing test coverage for the search_tags and get_multiple_tags tools that were added to the main code.
@patch("src.yeti_mcp.tools.get_yeti_client")
.vscode/mcp.json
Outdated
Comment on lines
+25
to
+26
| "GOOGLE_API_KEY": "${input:gemini-key}", | ||
| }, |
There was a problem hiding this comment.
Trailing comma after the last object property is unnecessary in JSON and may cause parsing issues in some environments.
Suggested change
| "GOOGLE_API_KEY": "${input:gemini-key}", | |
| }, | |
| "GOOGLE_API_KEY": "${input:gemini-key}" | |
| } |
.vscode/mcp.json
Outdated
Comment on lines
+25
to
+26
| "GOOGLE_API_KEY": "${input:gemini-key}", | ||
| }, |
There was a problem hiding this comment.
Trailing comma after the last object property is unnecessary in JSON and may cause parsing issues in some environments.
Suggested change
| "GOOGLE_API_KEY": "${input:gemini-key}", | |
| }, | |
| "GOOGLE_API_KEY": "${input:gemini-key}" | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.