Skip to content

Add get_multiple* tools#6

Merged
tomchop merged 5 commits intomainfrom
getmultiple
Jul 31, 2025
Merged

Add get_multiple* tools#6
tomchop merged 5 commits intomainfrom
getmultiple

Conversation

@tomchop
Copy link
Copy Markdown
Contributor

@tomchop tomchop commented Jul 31, 2025

No description provided.

@tomchop tomchop requested a review from Copilot July 31, 2025 21:08

This comment was marked as outdated.

@tomchop tomchop requested a review from Copilot July 31, 2025 21:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new get_multiple* tools to complement existing search functionality in the Yeti MCP server. The tools allow retrieving multiple objects by name rather than searching by partial matches.

  • Adds get_multiple_tags, get_multiple_entities, get_multiple_indicators, and get_multiple_dfiq tools
  • Updates test file patch paths from src.server.tools to src.yeti_mcp.tools
  • Adds VS Code MCP configuration file for development setup

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/yeti_mcp/tools.py Implements four new get_multiple* tools and one search_tags tool
tests/test_tools.py Updates import paths and adds tests for three new get_multiple* tools
.vscode/mcp.json Adds VS Code MCP server configuration for development
Comments suppressed due to low confidence (1)

tests/test_tools.py:118

  • Missing test coverage for the search_tags and get_multiple_tags tools that were added to the main code.
@patch("src.yeti_mcp.tools.get_yeti_client")

.vscode/mcp.json Outdated
Comment on lines +25 to +26
"GOOGLE_API_KEY": "${input:gemini-key}",
},
Copy link

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma after the last object property is unnecessary in JSON and may cause parsing issues in some environments.

Suggested change
"GOOGLE_API_KEY": "${input:gemini-key}",
},
"GOOGLE_API_KEY": "${input:gemini-key}"
}

Copilot uses AI. Check for mistakes.
.vscode/mcp.json Outdated
Comment on lines +25 to +26
"GOOGLE_API_KEY": "${input:gemini-key}",
},
Copy link

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma after the last object property is unnecessary in JSON and may cause parsing issues in some environments.

Suggested change
"GOOGLE_API_KEY": "${input:gemini-key}",
},
"GOOGLE_API_KEY": "${input:gemini-key}"
}

Copilot uses AI. Check for mistakes.
@tomchop tomchop merged commit 7fd0a0b into main Jul 31, 2025
3 checks passed
@tomchop tomchop deleted the getmultiple branch July 31, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants