Parameterized Subroute #1866
Draft
Parameterized Subroute #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, or even just the type arguments generally
…nd works as expected
…o context and no type args
L0neGamer
commented
Mar 31, 2025
| @@ -76,7 +76,7 @@ instanceNamesFromOpts (MkRouteOpts eq shw rd) = prependIf eq ''Eq $ prependIf sh | |||
|
|
|||
| -- | Generate the constructors of a route data type. | |||
| mkRouteCons :: [ResourceTree Type] -> Q ([Con], [Dec]) | |||
| mkRouteCons = mkRouteConsOpts defaultOpts | |||
| mkRouteCons = mkRouteConsOpts defaultOpts [] [] | |||
There was a problem hiding this comment.
I would appreciate recommendations on what to do for this.
L0neGamer
force-pushed
the
parameterized-subroute
branch
from
252cfbe to
952db23
Compare
L0neGamer
force-pushed
the
parameterized-subroute
branch
from
952db23 to
1e3260e
Compare
|
there are some really weird memcpy errors in CI which I doubt are my fault. |
|
ah, looks like the old TH operators take slightly more different parameters to what I expected. I can't fix this right now. |
|
Yeah I re-ran the failing builds because it didn't look like the failures were related to your change. Seemed to just be some transient Stack error. Ok, we can save this change for a rainy day. It's at least clear what problem we're solving here 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR:
Trying to solve #1865