Add yesod test getCookies utility#1815
Open
josephsumabat wants to merge 3 commits intoyesodweb:masterfrom
Open
Add yesod test getCookies utility#1815josephsumabat wants to merge 3 commits intoyesodweb:masterfrom
josephsumabat wants to merge 3 commits intoyesodweb:masterfrom
Conversation
parsonsmatt
approved these changes
Oct 10, 2023
Collaborator
parsonsmatt
left a comment
There was a problem hiding this comment.
lgtm! do you mind updating the cabal file to make an easy releate?
Thanks!
ddb7e1a to
67fab78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsRecently was trying to write a test which required that I clear cookies and set them again later on in the test.
Unfortunately
getRequestCookiesonly allows you to access the cookies in aRequestBuilder sitecontext since the type of request isRequestBuilder site () -> YesodExample site ()thus something likeunfortunately does not typecheck and you can only access the cookies from within the request builder. This PR adds the utility funciton
getCookieswhich simply enables the first use case allowing cookies to be accessed outside of a request context without resorting to using anIORefAfter submitting your PR: