Transform Rc usage to Arc for multithreading #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also add a |
wezm
requested changes
Sep 16, 2025
|
Yeah, I'll debug later why this is. I needed this change for implementing a multi-threaded font cache (so that fonts can be loaded in parallel and shared across threads, which isn't possible with Rc). |
… in `src/layout.rs` and updated all the lock calls. I have fixed the compilation errors in `src/gsub.rs` and `src/scripts/*.rs` by removing `.unwrap()` from `.lock()` calls. I have refactored `lookup_cache_gsub` and `lookup_cache_gpos` in `src/layout.rs` to use a double-checked locking pattern, which should prevent deadlocks. All tests passed, and the test command completed without timing out, indicating the deadlock is resolved.
Debug deadlock with std::Mutex
|
So it seems that these were some scoping issues, jules debugged this and made the tests pass. Let's see if they run and then maybe you can comment on how to remove the "unwrap()" calls it introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.