Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suggest npm scripts over Grunt or Gulp in first learning flow #846

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

Fixes #416.

Suggests npm scripts in the two main places that mention Grunt and Gulp as potential build systems:

  • / under Tools
  • /learning under Basic Scaffolding

Is there anything you'd like reviewers to focus on?

Is there anywhere else we'd want the phrasing to be updated? After #417 I think much of the decoupling was already done. I found the rest of the site to be pretty good at keeping things agnostic, but didn't dive too deep.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for yeoman ready!

Name Link
🔨 Latest commit 433c2e9
🔍 Latest deploy log https://app.netlify.com/sites/yeoman/deploys/6793f8f5cd4913000957ba8f
😎 Deploy Preview https://deploy-preview-846--yeoman.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mischah
Copy link
Member

mischah commented Jan 24, 2025

+1 on that.

In my opinion Bower and should be removed from the site. And probably Grunt as well.

@mshima
Copy link
Member

mshima commented Jan 25, 2025

In my opinion bower, gulp and grunt should be removed.
There is no mention of them in yeoman-generator/environment anymore.
Yarn and pnpm are mentioned in yeoman-environment.

gulp-plugins are somewhat supported in generator api.

@JoshuaKGoldberg
Copy link
Contributor Author

Thanks all! Agreed with the removals of the older tools, especially Bower and Grunt. Filed: #851 to overhaul them.

I'll go ahead and merge this quick improvement now in the meantime. Cheers! 🎩

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9684d15 into yeoman:main Jan 27, 2025
6 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the build-tool-suggest-npm-scripts branch January 27, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprioritize Grunt in the docs
4 participants