This repository was archived by the owner on Mar 26, 2018. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 69
Store filerev summary to file and strip summary paths #78
Open
eversteini
wants to merge
5
commits into
yeoman:master
Choose a base branch
from
eversteini:feature/saveSummaryToFile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b4cb832
store summary to file
eversteini 206beb5
saving summary and stripping summery are now independent
eversteini ff8f2a9
Restructured code based on comments
eversteini 5beef65
Removed .idea folder
eversteini b2dde35
Removed empty line
eversteini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ module.exports = function (grunt) { | |
try { | ||
var stat = fs.lstatSync(el.dest); | ||
if (stat && !stat.isDirectory()) { | ||
grunt.fail.fatal('Destination ' + el.dest + ' for target ' + target + ' is not a directory'); | ||
grunt.fail.fatal('Destination ' + el.dest + ' for target ' + target + ' is not a directory'); | ||
} | ||
} catch (err) { | ||
grunt.verbose.writeln('Destination dir ' + el.dest + ' does not exists for target ' + target + ': creating'); | ||
|
@@ -55,7 +55,11 @@ module.exports = function (grunt) { | |
grunt.log.error('options.process must be a function; ignoring'); | ||
} | ||
|
||
newName = [path.basename(file, ext), suffix, ext.slice(1)].join('.'); | ||
newName = [ | ||
path.basename(file, ext), | ||
suffix, | ||
ext.slice(1) | ||
].join('.'); | ||
} | ||
|
||
var resultPath; | ||
|
@@ -101,6 +105,44 @@ module.exports = function (grunt) { | |
next(); | ||
}, this.async()); | ||
|
||
if (options.stripPath) { | ||
// modify filerev summary | ||
var strippedSummary = {}; | ||
|
||
for (var key in filerev.summary) { | ||
if (filerev.summary.hasOwnProperty(key)) { | ||
var src; | ||
var dest; | ||
|
||
if (typeof options.stripPath === 'object') { | ||
if (options.stripPath.src) { | ||
src = options.stripPath.src; | ||
} | ||
|
||
if (options.stripPath.dest) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. }
if (options.stripPath.dest) { |
||
dest = options.stripPath.dest; | ||
} | ||
} else { | ||
src = options.stripPath; | ||
dest = options.stripPath; | ||
} | ||
|
||
var value = filerev.summary[key]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. }
var value = filerev.summary[key]; |
||
value = value.replace(dest, ''); | ||
key = key.replace(src, ''); | ||
strippedSummary[key] = value; | ||
} | ||
} | ||
|
||
filerev.summary = strippedSummary; | ||
} | ||
|
||
if (options.summaryFilePath) { | ||
// write filerev summary into file | ||
fs.writeFileSync(options.summaryFilePath, JSON.stringify(filerev.summary, null, 4)); | ||
grunt.log.writeln('Filerev summary was stored to ' + options.summaryFilePath); | ||
} | ||
|
||
grunt.filerev = filerev; | ||
}); | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.