Repository navigation
issue-3128: [Filestore] TTestEnv refactoring, part 1: create the subdomain in the TTestEnv constructor; rename CreateNode to AddDynamicNode - #5272
Merged
Conversation
…omain call into the TTestEnv constructor; rename CreateNode to AddDynamicNode
SvartMetal
changed the title
SvartMetal
added
the
filestore
Contributor
neihar
approved these changes
Feb 19, 2026
komarevtsev-d
approved these changes
Feb 19, 2026
qkrorlqr
added a commit
that referenced
this pull request
Feb 19, 2026
### Notes Follow-up for #5249 and #5269 `ResponseLogEntry` deletion via explicit `TEvDeleteResponseLogEntryRequest`s is implemented as "best-effort" (for simplicity) so we need to have some background op that deletes really old entries from time to time. Introduced `TEvRunRegularTasks` event - planning to add similar rarely firing tablet background tasks there in the future. The number of `ResponseLogEntr`ies should be tiny so iterating over all of them once a minute should not be a problem at all. I added `ResponseLogEntryCount` sensor to be able to notice its growth (if we introduce a bug which causes the number of these entries to grow). Fixes filestore tablet ut build after #5269 vs #5272 conflict as well ### Issue #2674
proller
pushed a commit
that referenced
this pull request
Mar 5, 2026
### Notes Follow-up for #5249 and #5269 `ResponseLogEntry` deletion via explicit `TEvDeleteResponseLogEntryRequest`s is implemented as "best-effort" (for simplicity) so we need to have some background op that deletes really old entries from time to time. Introduced `TEvRunRegularTasks` event - planning to add similar rarely firing tablet background tasks there in the future. The number of `ResponseLogEntr`ies should be tiny so iterating over all of them once a minute should not be a problem at all. I added `ResponseLogEntryCount` sensor to be able to notice its growth (if we introduce a bug which causes the number of these entries to grow). Fixes filestore tablet ut build after #5269 vs #5272 conflict as well ### Issue #2674
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3128