Open
Conversation
Contributor
Author
|
missing spark refactoring (tbd) |
Collaborator
|
Hi @vorel99 , Thank you for your contribution! In what concerns the proposed changes we will be analyzing and validating wether they fit the roadmap for the package. |
Contributor
|
@vorel99 The PR looks great. Whenever you are ready, please, mark it as Ready for review such that we can start the CI/CD. I'll also do some local tests to ensure everything is fine. |
6a3342a to
8f4f622
Compare
954f22c to
16c64c9
Compare
bcf3b49 to
b9f10cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my second refactoring pull request. First was #1302
My aim is to replace dictionaries with classes for easier feature developing.