-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthesizer): Support for MultiTable #81
Conversation
portellaa
commented
Jan 11, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is OK but I am concerned with the change of the typing from Optional to | None, or Union to | because this was introduced in Python 3.10.
If we want to support from Python 3.8 we cannot use it.
Ups forgot that. i will revert and test this with python 3.8, totally forgot |
@aquemy already reverted the changes to support python 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted