Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conn datasource creation #156

Merged
merged 12 commits into from
Feb 7, 2025
Merged

fix: conn datasource creation #156

merged 12 commits into from
Feb 7, 2025

Conversation

fabclmnt
Copy link
Contributor

@fabclmnt fabclmnt commented Feb 4, 2025

No description provided.

@fabclmnt fabclmnt marked this pull request as ready for review February 7, 2025 11:46
@fabclmnt fabclmnt requested review from portellaa February 7, 2025 11:47
portellaa
portellaa approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment about typeguard version, we are not fixing it and can have problems in future, buuut seems all good for me

pyproject.toml Outdated Show resolved Hide resolved
@fabclmnt fabclmnt requested review from gmartinsribeiro and removed request for portellaa February 7, 2025 16:07
@fabclmnt fabclmnt merged commit ec77c29 into main Feb 7, 2025
4 checks passed
@fabclmnt fabclmnt deleted the fix/conn_datasource_creation branch February 7, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portellaa portellaa portellaa approved these changes

@gmartinsribeiro gmartinsribeiro Awaiting requested review from gmartinsribeiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabclmnt @portellaa @azory-ydata