PRs that were forgotten in development #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copy&pasted over everything until I found the expected values in my xml file.
…ich potentially needs a unique number format ID Make sure that writeData with a date creates a style that has no collisions of its numFmtId with existing styles. By default, a style with numFmdId=165 (hard-coded!) is created by createStyle. When inserting that style into a workbook, we need to assign it a new, unique numFmtId if the workbook already has some custom number formats. The explicitly-called addStyle function checked for this case, but the implicitly-called classStyles function did not. Fixes #330.
…ich potentially needs a unique number format ID Make sure that writeData with a date creates a style that has no collisions of its numFmtId with existing styles. By default, a style with numFmdId=165 (hard-coded!) is created by createStyle. When inserting that style into a workbook, we need to assign it a new, unique numFmtId if the workbook already has some custom number formats. The explicitly-called addStyle function checked for this case, but the implicitly-called classStyles function did not. Fixes #330.
The function call to tempfile places the location of tmpDir at the per-session temporary directory, see Details section: https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/tempfile There is IMHO no need to recursively create the path to tmpDir: all path components will be available when the last component in the tmpDir path has been created. In fact, recursive directory creation can create problems on Windows, when the TEMP / TMP variable has been set to the root directory of an external drive ("D:\").
My suggestion is to use the dir.exists function to check if a file object exists and if it is a directory. See ?dir.exists for base::dir.exists - "dir.exists checks that the paths exist (in the same sense as file.exists) and are directories." In the documentation for file.exists, there's system-dependend limitations mentioned, in particular "What constitutes a ‘file’ is system-dependent, but should include directories. (However, directory names must not include a trailing backslash or slash on Windows.)": https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/files
-) Preserve grouping level -) Fix crashes -) Improve nested columns (also manually created by openxlsx) -) Properly set max outline level for rows/cols in the xml
…o arbitrary nesting -) groupRows did not properly overwrite existing groupings / append new ones -) Add new parameter level = -1 to the groupRows funtion to let openxlsx auto-detect the next grouping level -) Add test cast with several nested and unnested groupings to cover most use-cases -) Saving to an .xlsx file dropped the grouping if a row didn't contain content any -) Simplified xml-generation for grouped rows and row height. Fixes part of #138, implements the counterpart of #105 for rows, and properly implements the remaining missing parts of #294.
ungrouping a nested grouping will decrease the grouping level for the corresponding row/column by 1 and show the row/column. If the row/column is not grouped any more, it is removed form the outlineLevel structure.
-) implement generalized version of groupColumns, including auto-detecting the outline level -) consistent variable naming in groupRows and groupColumns
In the past, new columns were always appended to the end of the vector of <col... XML elements. This meant that the columns were not always in the correct order, so we need to sort them prior to writing to the xlsx file.
this reverts 312ea6c
… and wrap definitions
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 67.98% 70.71% +2.72%
==========================================
Files 34 35 +1
Lines 9007 9150 +143
==========================================
+ Hits 6123 6470 +347
+ Misses 2884 2680 -204 ☔ View full report in Codecov by Sentry. |
JanMarvin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs from the past.