Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the 'max_per_page' issue #1

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Fixing the 'max_per_page' issue #1

merged 1 commit into from
Jul 8, 2016

Conversation

Bastes
Copy link

@Bastes Bastes commented Jul 8, 2016

Hey ^^ thanks for fixing randym#42 (comment) ; there remained an issue though, which this patch fixes (at least on my build). Inspired from: thambley/activeadmin-xls#2

Hope you like it ^^

@ybart ybart merged commit 35a23ba into ybart:master Jul 8, 2016
@ybart
Copy link
Owner

ybart commented Jul 8, 2016

I'm no longer using this fork. However, I'm happy to merge it if it helps.

@Bastes
Copy link
Author

Bastes commented Jul 8, 2016

Well, now you're mentionning it... which fork are all the people using actually? (since it's apparent the original gem is not maintained anymore)

@ybart
Copy link
Owner

ybart commented Jul 8, 2016

Unfortunately, it looks like nobody is actively maintaining it.

@Bastes
Copy link
Author

Bastes commented Jul 8, 2016

I meant, you mentionned you're no longer using this fork ; I supposed it meant you're using another and was curious as to which ^^°

@ybart
Copy link
Owner

ybart commented Jul 8, 2016

In fact I am now working on an other project and no longer using the gem at all. But I believe my previous company might still use it.

@Bastes
Copy link
Author

Bastes commented Jul 8, 2016

Oh, well ^^° thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants