Fix Linux Build (#9) #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `s32` & `u32` to be typed as `signed int` & `unsigned int` instead of `signed long int` & `unsigned long int`, as this resolves to 64 bits on x64 Linux & 32 bits on Windows, while `signed int` & `unsigned int` resolve to 32 bits on Windows & x64 Linux.
|
Sorry, I renamed the branch; didn't think that would happen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Changes
s32&u32to be typed assigned int&unsigned intinstead ofsigned long int&unsigned long int, as this resolves to 64 bits on x64 Linux & 32 bits on Windows, whilesigned int&unsigned intresolve to 32 bits on Windows & x64 Linux.This change has been tested to work on Windows & x64 Linux.