[Yarpc-Go] Implement Metrics Tag Decorator #2398
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oneporter
requested changes
Jun 26, 2025
oneporter
reviewed
Jul 1, 2025
oneporter
previously approved these changes
Jul 3, 2025
oneporter
previously approved these changes
Jul 4, 2025
oneporter
previously approved these changes
Jul 7, 2025
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
3 times, most recently
from
32d7848 to
f2e0b69
Compare
pulkit4tech
reviewed
Jul 15, 2025
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
from
9b0bf85 to
33b6fdc
Compare
pulkit4tech
requested changes
Jul 18, 2025
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
from
33b6fdc to
4e21cee
Compare
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
from
4e21cee to
0d2dc30
Compare
pulkit4tech
requested changes
Jul 30, 2025
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
from
0d2dc30 to
cf7e69f
Compare
pulkit4tech
requested changes
Jul 31, 2025
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
2 times, most recently
from
7912930 to
cef5207
Compare
pulkit4tech
force-pushed
the
sg-custom-tenancy
branch
from
cef5207 to
1b74a54
Compare
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
2 times, most recently
from
3324616 to
c3a78f8
Compare
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
3 times, most recently
from
ff06f46 to
87f7a58
Compare
Update Comment address address comment resolve lint error update copyright changing interface location gRPC reflection server (yarpc#2371) * gRPC reflection server * license header * add README.md for gRPC reflection * updated .codecov.yml [Yarpc-Go] Implement Metrics Tag Decorator Update Comment address address comment resolve lint error update copyright changing interface location gRPC reflection server (yarpc#2371) * gRPC reflection server * license header * add README.md for gRPC reflection * updated .codecov.yml nit Revert "gRPC reflection server (yarpc#2371)" This reverts commit 056f218. nit limiting logging per edge limiting logging per edge nits decoratortags as pointer adding sampledLogger + modifying interface remove ctx remove ctx adding decorator call options using context
sakshi4016
force-pushed
the
sg-custom-tenancy
branch
from
87f7a58 to
845766f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and context for reviewers: one partner, one stranger
This PR introduces a Metric Tag Decorator interface that allows service owners to add custom tags to the inbound and outbound metrics emitted by YARPC-Go.
The main motivation for this change is to support adding a custom tenancy tag to YARPC metrics.
To prevent high cardinality issues, this tag is opt-in. By default, the tenancy tag is set to dropped, but service owners can override it by providing implementation of the TenancyTagDecorator interface.
Docs (package doc)
ERD : https://docs.google.com/document/d/1ceTSRSYCaRO5yDXQ6FFgyfloxrIHWrD6_CXVWdi00VU/edit?usp=sharing
RELEASE NOTES:
Implementing MetricsTagsDecorator which would allows teams to add custom tags to Yarpc inbound / outbound metrics