[patch] Add refresh interval #15

kevindiu · 2019-10-04T09:15:12Z

No description provided.

service/role.go

usecase/tenantd.go

codecov-io · 2019-10-04T09:16:51Z

Codecov Report

Merging #15 into master will increase coverage by 2.31%.
The diff coverage is 93.83%.

@@            Coverage Diff            @@
##           master     #15      +/-   ##
=========================================
+ Coverage   93.99%   96.3%   +2.31%     
=========================================
  Files          10      10              
  Lines         483     569      +86     
=========================================
+ Hits          454     548      +94     
+ Misses         19      12       -7     
+ Partials       10       9       -1

Impacted Files	Coverage Δ
config/config.go	`88.23% <ø> (ø)`	⬆️
usecase/tenantd.go	`91.3% <60%> (-8.7%)`	⬇️
service/role.go	`97.23% <96.32%> (+13.74%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7627b3d...ade5e8d. Read the comment docs.

service/role.go

service/role_test.go

service/role.go

service/role_test.go

* update golang version * [patch] release

service/role_test.go

usecase/tenantd.go

…athenz-client-sidecar into add_refresh_interval

Co-Authored-By: Windz <[email protected]>

service/role.go

…okRefreshInterval to 1min

service/role.go

WindzCUHK · 2019-10-23T05:10:54Z

LGTM

service/role.go

kevindiu added 5 commits October 4, 2019 17:02

add refresh functionality

5e669ec

update dependencies version

b2ab80d

update golang version to 1.13

c4e3466

fix failed test case

98436de

update go.mod

717adb9

golangcibot reviewed Oct 4, 2019

View reviewed changes

kpango added 2 commits October 7, 2019 13:55

include proxyForPrincipal field to the object key

8e571bd

add test case and fix encode and decode funcion

8a953b7

golangcibot reviewed Oct 7, 2019

View reviewed changes

kevindiu force-pushed the add_refresh_interval branch from 4aa3534 to 8a953b7 Compare October 8, 2019 04:56

fix test case order and add TODO test case stub

9c33268

golangcibot reviewed Oct 8, 2019

View reviewed changes

add test case

8b12582

golangcibot reviewed Oct 8, 2019

View reviewed changes

service/role.go Outdated Show resolved Hide resolved

service/role_test.go Show resolved Hide resolved

service/role_test.go Show resolved Hide resolved

kevindiu and others added 3 commits October 10, 2019 15:38

[patch] update golang version (#16)

841c41e

* update golang version * [patch] release

fix

903c459

Add test

78a339f

golangcibot reviewed Oct 11, 2019

View reviewed changes

service/role_test.go Show resolved Hide resolved

service/role_test.go Show resolved Hide resolved

service/role_test.go Show resolved Hide resolved

kevindiu added 2 commits October 11, 2019 17:46

add test case

1d4cca2

add test case

e59dca1

golangcibot reviewed Oct 16, 2019

View reviewed changes

add test case and fix logic

d4c9b03

golangcibot reviewed Oct 17, 2019

View reviewed changes

add test case

43e8eac

golangcibot reviewed Oct 17, 2019

View reviewed changes

fix test case and change default token expiry time and fix

8a79c03

golangcibot reviewed Oct 18, 2019

View reviewed changes

usecase/tenantd.go Show resolved Hide resolved

kevindiu added 2 commits October 18, 2019 10:29

comment failed test case due to different env.

818ddb1

fix gocibot

4b4afd3

kevindiu added 3 commits October 18, 2019 14:46

small refactor

070da5e

Merge branch 'add_refresh_interval' of https://github.com/yahoojapan/…

35c23d1

…athenz-client-sidecar into add_refresh_interval

set max expiry only if user specify it

129a3f8

WindzCUHK mentioned this pull request Oct 18, 2019

Provide sync method in RoleService instead #20

Closed

kevindiu and others added 3 commits October 21, 2019 09:37

fix comments

a795564

Update service/role.go

b423fa6

Co-Authored-By: Windz <[email protected]>

fix

7d4cd34

WindzCUHK reviewed Oct 21, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

WindzCUHK reviewed Oct 21, 2019

View reviewed changes

service/role.go Outdated Show resolved Hide resolved

kevindiu added 2 commits October 21, 2019 10:48

fix

a516f1d

roles ordering

102988d

golangcibot reviewed Oct 21, 2019

View reviewed changes

service/role.go Outdated Show resolved Hide resolved

service/role.go Outdated Show resolved Hide resolved

WindzCUHK reviewed Oct 21, 2019

View reviewed changes

service/role.go Outdated Show resolved Hide resolved

service/role.go Outdated Show resolved Hide resolved

fix retry count and minor changes

3b9463f

golangcibot reviewed Oct 21, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

service/role.go Outdated Show resolved Hide resolved

service/role.go Outdated Show resolved Hide resolved

do not trim on roles and make the refreshRoleToken channel is buffer

59250f5

golangcibot reviewed Oct 21, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

service/role.go Outdated Show resolved Hide resolved

do not use buffer channel on StartRoleUpdaterm and chang the expiryHo…

748830d

…okRefreshInterval to 1min

golangcibot reviewed Oct 21, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

WindzCUHK reviewed Oct 21, 2019

View reviewed changes

service/role.go Outdated Show resolved Hide resolved

WindzCUHK reviewed Oct 21, 2019

View reviewed changes

service/role.go Outdated Show resolved Hide resolved

fix typo

0b62730

golangcibot reviewed Oct 21, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

add test case and revert change of the buffered channel

d2f9d73

golangcibot reviewed Oct 23, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

[patch] release

ade5e8d

golangcibot reviewed Oct 23, 2019

View reviewed changes

service/role.go Show resolved Hide resolved

kevindiu merged commit e2f2a1f into master Oct 23, 2019

WindzCUHK deleted the add_refresh_interval branch February 14, 2020 05:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[patch] Add refresh interval #15

[patch] Add refresh interval #15

kevindiu commented Oct 4, 2019

codecov-io commented Oct 4, 2019 •

edited

Loading

WindzCUHK commented Oct 23, 2019

[patch] Add refresh interval #15

[patch] Add refresh interval #15

Conversation

kevindiu commented Oct 4, 2019

codecov-io commented Oct 4, 2019 • edited Loading

Codecov Report

WindzCUHK commented Oct 23, 2019

codecov-io commented Oct 4, 2019 •

edited

Loading