Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark for Storm Trident API #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ptgoetz
Copy link

@ptgoetz ptgoetz commented Dec 18, 2015

No description provided.

@ptgoetz
Copy link
Author

ptgoetz commented Jan 22, 2016

How does one trigger the CLA bot?

@yahoocla
Copy link

CLA is valid!

@ptgoetz
Copy link
Author

ptgoetz commented Jan 22, 2016

I guess I just found out. :)

@@ -258,6 +262,21 @@ run() {
run "STOP_KAFKA"
run "STOP_REDIS"
run "STOP_ZK"
elif [ "TRIDENT_TEST" = "$OPERATION" ];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the help, echos below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@revans2
Copy link
Collaborator

revans2 commented Jan 22, 2016

@knusbaum we never added in the docs how to run the validation test to be sure the code is doing the right thing. Could you post it here. I will add it to the docs/automated script and test the trident code.

tweise pushed a commit to tweise/streaming-benchmarks that referenced this pull request Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants