fix(clp-s): Improve error reporting for directory-creation failure during compression.

[gibber9809]

Description

This PR improves error reporting when failing to create a directory during compression (this issue was encountered in #669). Previously we were using the no-throw version of std::filesystem::create_directory, but were not bothering to log the specific system error.

We also wrap the whole compression flow in try/catch so that we can exit gracefully on otherwise uncaught exceptions.

Validation performed

• Attempted to create archives in directory without correct permissions and verified that expected error log was produced

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved error handling during archive creation and compression processes.
  • Enhanced logging for directory creation and compression failures.

• Improvements

  • More detailed error reporting with context-specific log messages.
  • Refined exception handling to provide clearer feedback on operational issues.

These updates improve the system's error reporting and diagnostic capabilities, making it easier to identify and troubleshoot potential problems during archive and compression operations.

[coderabbitai]

Walkthrough

The pull request introduces improved error handling in two components of the CLP (Compressed Log Processor) system. In ArchiveWriter.cpp, the error reporting mechanism for directory creation has been enhanced to provide more detailed logging. Similarly, in clp-s.cpp, the compression process error handling has been updated to catch and log exceptions more comprehensively. These changes aim to improve error visibility and diagnostic capabilities during archive and compression operations.

Changes

File	Change Summary
components/core/src/clp_s/ArchiveWriter.cpp	- Modified error handling for archive directory creation - Replaced ErrorCodeErrno with ErrorCodeFailure - Added detailed error logging using SPDLOG_ERROR
components/core/src/clp_s/clp-s.cpp	- Enhanced exception handling in main function - Added try-catch block for compress function - Implemented error logging for compression failures

Possibly related PRs

• fix(core-clp): Advance to the next message when a message has an out-of-range timestamp when searching archives (fixes #659). #660: Error handling and index management improvements in find_message_matching_query method, sharing a similar focus on error reporting enhancements

Suggested reviewers

• kirkrodrigues

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 418dc01 and 93b44f5.

📒 Files selected for processing (1)

• components/core/src/clp_s/ArchiveWriter.cpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/core/src/clp_s/ArchiveWriter.cpp

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: centos-stream-9-static-linked-bins
• GitHub Check: ubuntu-focal-static-linked-bins
• GitHub Check: ubuntu-jammy-static-linked-bins
• GitHub Check: centos-stream-9-dynamic-linked-bins
• GitHub Check: ubuntu-focal-dynamic-linked-bins
• GitHub Check: ubuntu-jammy-dynamic-linked-bins
• GitHub Check: build-macos (macos-14, true)
• GitHub Check: lint-check (ubuntu-latest)
• GitHub Check: build-macos (macos-13, false)
• GitHub Check: lint-check (macos-latest)
• GitHub Check: build-macos (macos-13, true)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kirkrodrigues]

Minor suggestion.