feat(Integration): Remove/Stop Integration #328
Conversation
- Added abort controller signal - map abort errors - init sync jobs on integration completes
- show dialog for confirmation - show appropriate signals
| @@ -94,7 +94,11 @@ export const getRelativeTime = (oldTimestamp: number) => { | |||
| const MAX_RETRIES = 10 | |||
|
|
|||
| const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)) | |||
|
|
|||
| export const isAbortError = (error: any) => | |||
There was a problem hiding this comment.
We won't modify for now, but if the error is specific to a app and entity then we need to ensure that is documented somewhere.
In future we can do this in a mapper way for errors across apps.
No need to change much for now other than document the error app.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces the functionality to remove or stop integrations, handle these operations asynchronously, clean up Vespa data, and remove associated connectors. It also fixes an issue where SyncJobs were running when the integration was not in a connected state. The changes include modifications to the frontend to add UI elements for stopping/disconnecting integrations, as well as backend changes to handle the removal/stopping logic and background jobs. Overall, the changes seem well-structured and address the described problem effectively.
Summary of Findings
Merge Readiness
The code appears to be well-structured and addresses the intended functionality. However, due to the complexity and scope of the changes, thorough testing is crucial. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
Description
This PR includes:
Additionally, this also includes a fix for SyncJobs running when the integration is not connected or still in the process of connecting:
Testing
Tested via oAuth integration