[Misc] Record the dependency-upgrade commit prefix and issue description rules - #98
Open
manuelleduc wants to merge 6 commits into
Open
[Misc] Record the dependency-upgrade commit prefix and issue description rules#98manuelleduc wants to merge 6 commits into
manuelleduc wants to merge 6 commits into
Conversation
…ion rules A dependency bump was committed as [Misc] because the dependency was declared through a pnpm catalog entry, which hides whether it is a runtime or a dev-only dependency; and the issue that replaced it linked only the target release, losing the five intermediate releases the bump crosses. * commit-messages: split dependency upgrades on the existing user-visible test — dev/peer/test-scoped is [Misc], anything in dependencies or a runtime Maven dependency needs an issue — and warn that a shared version catalog hides which one it is. * jira: add the dependency-upgrade issue shape (summary, Dependency Upgrades component, description = raw release-note URLs of every version crossed) and why that description has to go over REST.
…nical steps * commit-messages: the body's bullets carry what distinguishes this commit, so a lone dependency bump needs no body at all.
…ipt dependency * dependencies: the pnpm and node versions the build uses are pinned in the xwiki-commons parent pom, so the lockfile must be regenerated with that pnpm and then deduped — not with whatever pnpm is on PATH.
* commit-messages: a dependencies entry is runtime only if the package holding it is reached at runtime, so a lint or build package's own dependencies stay [Misc] — being published is not evidence to the contrary.
* Five manifests carry one version, so every concurrent pull request conflicted with every other one on those same five lines, over something that was never part of either change. The release is now cut on master after the merge by scripts/release.mjs, and scripts/validate.mjs fails a branch that touches a version field. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…rade-commit-prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two OKF gaps surfaced while bumping
vue-i18nin xwiki-platform.okf/conventions/commit-messages.md— dependency upgrades split on the same user-visible test as everything else: dev/peer/test-scoped is[Misc], anything independenciesor a runtime Maven dependency needs an issue. The trap worth recording is that a shared version catalog (pnpmcatalog:, apom.xmlproperty) hides which one it is, and one runtime declaration among several dev-only ones is enough to require the issue.okf/servers/jira.md— the dependency-upgrade issue shape: summaryUpgrade to <dependency> <version>, component Dependency Upgrades, description = the raw release-note URLs of every version crossed, not just the target's. Also notes thatjira-clirewrites a plain URL as[url|url], so the description has to be set over REST to stay raw.Patch version bump (1.5.0 → 1.5.1) across the five synced fields;
node scripts/validate.mjspasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01WuYezRDJKK4fPa7xLRNG5T