Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add results processing tool and stage to the interop workflow. #45

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

chris-wood
Copy link
Collaborator

@chris-wood chris-wood commented Mar 19, 2021

Ready to go!

This change adds a new utility program to process the output of each interop test case and upload it to a remote server for storage. This will let us render the interop results (a la https://interop.seemann.io/) by querying the contents of the server.

Screen Shot 2021-03-19 at 3 05 20 PM

@cjpatton
Copy link
Collaborator

Not sure how to review this, as I'm missing the context for the change. Can you provide a bit of context?

@cjpatton
Copy link
Collaborator

Following the instructions in the README, the last command does this:

$ ./bin/runner --client=cloudflare-go --server=boringssl --testcase=dc
Error generating test inputs.

@chris-wood
Copy link
Collaborator Author

Not sure how to review this, as I'm missing the context for the change. Can you provide a bit of context?

Sure: this just dumps the test output into a bucket so that we can view the data elsewhere. (This is similar to the QUIC interop runner, which uploads all test output artifacts to another server, and that server then renders the results.)

Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test, so take this approval with a grain of salt. One comment about logging in Go.

Copy link
Owner

@xvzcf xvzcf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. At some point we might want to separate all the cert, DC, etc. artifact generation utilities into another library but we can deal with that when we get there.

@chris-wood chris-wood merged commit 3df73b0 into main Mar 23, 2021
@chris-wood chris-wood deleted the caw/post-results branch March 23, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants