Upgrade ECH target to draft-ietf-tls-esni-10 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Mar 19, 2021
| @@ -5,10 +5,10 @@ FROM golang:latest AS builder | |||
|
|
|||
| RUN apt-get update && \ | |||
| apt-get install git | |||
| RUN git clone https://github.com/cloudflare/go /cf | |||
| RUN git clone --branch caw/ech-10 https://github.com/cloudflare/go /cf | |||
| && cd nss \ | ||
| && hg pull -u -r 98542d9c204f8e91336f0a36239d776d82dc8989 https://hg.mozilla.org/projects/nss-try \ |
There was a problem hiding this comment.
These change will be reverted once your PR lands.
|
Closing as this has gone stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the NSS and Cloudflare-Go endpoints to run the latest draft of ECH. It also updates the test-input generation code accordingly.
DO NOT MERGE: Before merging, the following changes need to be made.
Revert change to impl-endpoint/cloudfflare-go/Dockerfile. Once Implement ECH-10. cloudflare/go#65 lands, update the file with the new commit.NOTE: This PR confirms interop of ECH-10 between NSS and Cloudflare-Go. To test the NSS client against the Cloudflare-Go server, do
Replace "ech-accept" with "ech-reject" to exercise the rejection codepath. Swap "nss" and "cloudflare-go" to test the Cloudflare-Go client against the NSS server.
cc/ @martinthomson, @chris-wood