Ensure all servers run forever #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-wood
requested changes
Feb 13, 2021
cjpatton
force-pushed
the
cjpatton/kill-server
branch
from
f580779 to
f2ee542
Compare
cjpatton
changed the title
cjpatton
force-pushed
the
cjpatton/kill-server
branch
from
1709b53 to
cef75c4
Compare
chris-wood
approved these changes
Feb 19, 2021
|
@cjpatton can you please resolve conflicts? We can merge afterwards. |
xvzcf
approved these changes
Feb 19, 2021
cjpatton
force-pushed
the
cjpatton/kill-server
branch
from
6f434a7 to
070e626
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #27.
The scope of each test case is a single connection attempt. BoringSSL and Cloudflare-Go servers quit after one connection attempt, but the NSS and rustls servers listen forever. This change ensures that all of the servers run forever so that the code that calls
docker-compose upis responsible for timing out.