Add "ech-reject" test case for nss and cloudflare-go #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/ech-reject
branch
2 times, most recently
from
766eb56 to
78dee24
Compare
xvzcf
reviewed
Feb 12, 2021
xvzcf
reviewed
Feb 12, 2021
chris-wood
requested changes
Feb 13, 2021
| } | ||
| } else { | ||
| log.Fatalf("unknown role \"%s\"", *role) | ||
| log.Fatalf("Unknown role \"%s\"", *role) |
There was a problem hiding this comment.
This makes me wonder if we should have a sentinel return value for invalid parameters. @xvzcf, thoughts?
There was a problem hiding this comment.
Will address this in the follow-up PR.
There was a problem hiding this comment.
See #39, though I'm not sure this totally addresses the point!
In this test case, the client offers ECH using an invalid config, the server rejects, and the client aborts the connection. This adds support for this test case to the nss and cloudflare-go endpoints.
cjpatton
force-pushed
the
cjpatton/ech-reject
branch
from
eb8762e to
f7f009c
Compare
chris-wood
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #27.
Adds a test case for exercising the ECH rejection path, with initial support for NSS and Cloudflare-Go.
In this test case, the client offers ECH with an invalid config, the server rejects, and the client aborts the connection with "ech_required" alert. They don't attempt to retry the connection with the retry configs.
Thanks to @kjacobs-moz for help getting the NSS client endpoint right!