Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding license information. #34

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Adding license information. #34

merged 1 commit into from
Feb 10, 2021

Conversation

xvzcf
Copy link
Owner

@xvzcf xvzcf commented Feb 9, 2021

I aimed to follow the KDE Licensing Guidelines, which follows the specifications of the reuse tool, which does license checking and linting.

@xvzcf xvzcf requested review from chris-wood and cjpatton February 9, 2021 15:17
@xvzcf xvzcf marked this pull request as draft February 9, 2021 15:18
@xvzcf xvzcf force-pushed the add-license branch 2 times, most recently from 419a93f to 07ded54 Compare February 10, 2021 21:21
@xvzcf xvzcf marked this pull request as ready for review February 10, 2021 21:23
Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, though I'm wondering if you tried to run the tool yourself? Seems like having this in our pockets would be useful, assuming it's not too hard to run ourselves.

@xvzcf
Copy link
Owner Author

xvzcf commented Feb 10, 2021

I just had to run reuse lint, and here's the output:

# SUMMARY

* Bad licenses:
* Deprecated licenses:
* Licenses without file extension:
* Missing licenses:
* Unused licenses:
* Used licenses: Apache-2.0, BSD-3-Clause, CC0-1.0, MIT
* Read errors: 0
* Files with copyright information: 33 / 33
* Files with license information: 33 / 33

Congratulations! Your project is compliant with version 3.0 of the REUSE Specification :-)

And I agree, once I start working on the CI runner, I was planning on adding this to the CI for pull requests.

@xvzcf xvzcf merged commit 364f863 into main Feb 10, 2021
@xvzcf xvzcf deleted the add-license branch February 10, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants