cert-util: Add -make-ech-key #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/ech-gen
branch
2 times, most recently
from
3e799dc to
3c01bb9
Compare
chris-wood
approved these changes
Jan 6, 2021
| if len(clientFacingCert.DNSNames) == 0 { | ||
| fatalIfErr(errors.New("input certificate does not specify a DNS name"), keyGenErrMsg) | ||
| } | ||
| template.PublicName = clientFacingCert.DNSNames[0] |
There was a problem hiding this comment.
This might not be a valid public facing name (*.example.com) -- should we check this rather than just picking the first one?
There was a problem hiding this comment.
Hrm ... good point. I will fix this.
There was a problem hiding this comment.
Well, DNSNames[0] is hard-coded as "server" here, which is already not a valid public name. (It needs to be an SNI.) I just decided to add this as a TODO and will address it in #20.
This feature generates an ECH key using the DNS name specified by the input certificate as the public name. The key is written to the file specified by the -key-out flag and the ECHConfigs (consumed by the client) is written to the file specified by the -out flag.
cjpatton
force-pushed
the
cjpatton/ech-gen
branch
from
3c01bb9 to
90d6310
Compare
chris-wood
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature generates an ECH key using the DNS name specified by the
input certificate as the public name. The key is written to the file
specified by the -key-out flag and the ECHConfigs (consumed by the
client) is written to the file specified by the -out flag.