refactor: remove Alert and BlockquoteFigure extensions along with related styles and dependencies#307
Conversation
…ated styles and dependencies
❌ Deploy Preview for ornate-blancmange-89db6b failed. Why did it fail? →
|
Summary of ChangesHello @xun082, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the editor's functionality by removing unused or redundant extensions like Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| getBoundingClientRect: () => { | ||
| const start = view.coordsAtPos(from); | ||
| const end = view.coordsAtPos(to); | ||
|
|
||
| return { | ||
| top: Math.min(start.top, end.top), | ||
| bottom: Math.max(start.bottom, end.bottom), | ||
| left: Math.min(start.left, end.left), | ||
| right: Math.max(start.right, end.right), | ||
| width: Math.abs(end.right - start.left), | ||
| height: Math.abs(end.bottom - start.top), | ||
| x: Math.min(start.left, end.left), | ||
| y: Math.min(start.top, end.top), | ||
| }; | ||
| try { | ||
| const docSize = state.doc.content.size; | ||
| const clampedFrom = Math.max(0, Math.min(from, docSize)); | ||
| const clampedTo = Math.max(0, Math.min(to, docSize)); | ||
| const start = view.coordsAtPos(clampedFrom); | ||
| const end = view.coordsAtPos(clampedTo); | ||
|
|
||
| return { | ||
| top: Math.min(start.top, end.top), | ||
| bottom: Math.max(start.bottom, end.bottom), | ||
| left: Math.min(start.left, end.left), | ||
| right: Math.max(start.right, end.right), | ||
| width: Math.abs(end.right - start.left), | ||
| height: Math.abs(end.bottom - start.top), | ||
| x: Math.min(start.left, end.left), | ||
| y: Math.min(start.top, end.top), | ||
| }; | ||
| } catch { | ||
| return new DOMRect(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
在 updateMenu 方法中，getBoundingClientRect 的实现（L93-L113）与 autoUpdate 中的实现（L172-L195）几乎完全相同。这种代码重复会增加维护成本，当需要修改此逻辑时，可能需要在两个地方进行同步修改。
建议将这部分重复的逻辑提取到一个独立的辅助函数中，然后在两个地方调用它，以提高代码的可维护性和复用性。
| case 'underline': | ||
| result = `<u>${result}</u>`; | ||
| break; |
There was a problem hiding this comment.
在将内容序列化为 Markdown 时，下划线（underline）格式被转换为了 HTML 的 <u> 标签。然而，<u> 并不是标准的 Markdown 语法，这可能导致在不支持 HTML 的 Markdown 渲染器中显示不正确。
建议直接将带下划线的文本作为普通文本处理，以保证更好的兼容性。如果确实需要保留此格式，可以考虑添加注释说明其目的。
| case 'underline': | |
| result = `<u>${result}</u>`; | |
| break; | |
| case 'underline': | |
| // Underline is not a standard Markdown format, so it's serialized as plain text. | |
| break; |
1 participant
PR 描述
PR 类型
Issue 关联
Closes #
其他信息