Feature: Add basic REST Webserver #25
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovo89
reviewed
Jun 24, 2025
Comment on lines
+13
to
+15
| [submodule "ext/mongoose"] | ||
| path = ext/mongoose | ||
| url = https://github.com/cesanta/mongoose.git |
Collaborator
There was a problem hiding this comment.
Submodules vs. FetchContent - not sure when to use which?
Comment on lines
+6
to
+9
| // clang-format off | ||
| #include "ch.h" | ||
| #include "hal.h" | ||
| // clang-format on |
Collaborator
There was a problem hiding this comment.
What would it be without the exception? I think it should be <ch.h> and <hal.h> because they will never be found locally.
| if (mg_match(hm->method, mg_str("POST"), NULL)) { | ||
| if (mg_match(hm->uri, mg_str("/api/robot_type"), NULL)) { | ||
| File robot_type; | ||
| robot_type.open("robot_type.txt"); |
Collaborator
There was a problem hiding this comment.
As mentioned in Discord, I think it might be more future-proof to use JSON everywhere, for example to have subtypes like Worx with or without knob.
| /* Define LWIP_ERRNO_STDINCLUDE if you want to include <errno.h> here */ | ||
| #ifdef LWIP_ERRNO_STDINCLUDE | ||
| #include <errno.h> | ||
| #include <sys/errno.h> |
Collaborator
There was a problem hiding this comment.
This looks strange and generally I wouldn't modify the included projects... but I don't want to spend time trying to figure out a better solution. I see you already tried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.