This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Deselect/select all regions logic fix #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no need to grey out deselectall and selectall buttons. - this just ensure you are always able to selectall and deselectall
- this commit ensure that when the user clicks on select or deselect region then clicks on deselect or select all that the region select ui mode is exited.
|
The logic was originally designed by someone to make the deselect all button disabled if all stations are indeed disabled, but since the functionality was implemented incorrectly, I agree that it's better to disable it completely and use your elegant version of the code :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the unnecessary wrong logic which handled the button states for this. It works now.