-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XEP-0482: Add the XML Schema #1423
base: master
Are you sure you want to change the base?
Conversation
3016485
to
744de35
Compare
<xs:element name='invite'> | ||
<xs:complexType> | ||
<xs:sequence> | ||
<xs:element ref='jingle'/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<jingle/>
element is meant to be optional. This would implicitly be solved by changing to <xs:sequence><xs:choice maxOccurs='unbounded'>
.
|
||
<xs:element name='invite'> | ||
<xs:complexType> | ||
<xs:sequence> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think <xs:sequence><xs:choice maxOccurs='unbounded'>
might be more appropriate here.
While currently not specified, the idea was that the order of elements inside <invite/>
indicates the sending clients priority for each of the ways to join the call, meaning a recipient client should pick the first option it deems appropriate, when of course the receiving user might be empowered to override this.
For regular calls this is likely always first <jingle/>
and then <external/>
, but for an multi-party audio call it might be as complex as <meeting type='jitsi' /><external uri='https://jitsi...' /><jingle jid='mixer@jitsi...' /><external uri='tel:...' />
,where the first two receive individual audio streams from each participant whereas the third and fourth go through a mixer that mixes them in a single audio stream and thus are inferior.
<xs:complexType> | ||
<xs:sequence> | ||
<xs:element ref='jingle'/> | ||
<xs:element ref='external' minOccurs='0' maxOccurs='unbounded'/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add explicit <xs:any namespace='##other' />
here to indicate that this is explicitly intended as an extension point.
No description provided.