Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: block lists to check and test resolvers #48

Merged
merged 3 commits into from
Jun 15, 2024
Merged

RF: block lists to check and test resolvers #48

merged 3 commits into from
Jun 15, 2024

Conversation

kynrai
Copy link
Collaborator

@kynrai kynrai commented Jun 14, 2024

  • Move block list logic to checks
  • Create IP resolver interfaces
    • Inject resolvers
  • Add code cov file for code that just calls stdlib

@kynrai
RF: block lists to check and test resolvers
0d1902c 
- Move block list logic to checks
- Create IP resolver interfaces
  - Inject resolvers
- Add code cov file for code that just calls stdlib
@kynrai kynrai requested a review from Lissy93 as a code owner June 14, 2024 13:38
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 59.75% <86.04%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/server.go 84.21% <100.00%> (ø)
checks/block_lists.go 94.59% <94.59%> (ø)
checks/checks.go 0.00% <0.00%> (ø)
handlers/block_lists.go 75.00% <33.33%> (-19.12%) ⬇️

... and 3 files with indirect coverage changes

Lissy93
Lissy93 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kynrai kynrai merged commit 97fbfce into main Jun 15, 2024
2 of 3 checks passed
@kynrai kynrai deleted the rf/block_lists branch June 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kynrai @Lissy93