feat(let): add strftime function #1373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1373 will improve performances by 32.52%Comparing Summary
Benchmarks breakdown
|
dlovell
reviewed
Nov 5, 2025
dlovell
reviewed
Nov 10, 2025
| def temporal_strftime(array: dt.Timestamp(scale=9), pattern: dt.string) -> dt.string: | ||
| pattern, *_rest = typing.cast(pa.StringArray, pattern).unique().to_pylist() | ||
|
|
||
| if len(_rest) > 0: |
Collaborator
There was a problem hiding this comment.
let's use "truth value testing" here: if rest:
https://docs.python.org/3/library/stdtypes.html#truth-value-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1372