Skip to content

feat: Adds support for GCC 15 toolchain #6929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

feat: Adds support for GCC 15 toolchain #6929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions xmake/toolchains/gcc-15/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
includes(path.join(os.scriptdir(), "../gcc/xmake.lua"))
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This includes directive will execute the entire ../gcc/xmake.lua script. That script contains a call to toolchain_gcc() at the end, which defines a generic gcc toolchain. This means that every time this gcc-15 toolchain file is loaded, it will also define the generic gcc toolchain, which is likely an unintended side effect and can be inefficient.

This pattern seems to be inherent in the project's structure, but it's worth pointing out. A potential fix would involve refactoring gcc/xmake.lua to not call toolchain_gcc() when it's being included by other files. This would require changes outside of this PR. As it stands, this could be a source of subtle issues or performance problems.

Copy link
Contributor Author

@romeoxbm romeoxbm Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is something I already noticed while working on #6899. I may consider addressing it in a separate PR, if my limited spare time allows.


toolchain_gcc("15")
Loading