Merged
Conversation
Let most values of TlsConfig come from non-config-file sources.
Collaborator
Author
|
Fixes #290 . |
manimaul
reviewed
Sep 20, 2018
| Long sessionTimeout) { | ||
| // Validate that *all* parameters were set in the builder. | ||
| String errorMessage = "{} must be set in builder"; | ||
| Preconditions.checkNotNull(useSsl, errorMessage, "useSsl"); |
Collaborator
There was a problem hiding this comment.
i'd expect lombok to be able to make this not null requirement check with an annotation
Collaborator
There was a problem hiding this comment.
lombok.Builder is lacking in generated validation hooks, for that reason we've moved this sort of functionality over to google auto builder, we can refactor later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let most values of TlsConfig come from non-config-file sources.
This ended up going through a few iterations, but it seems reasonable now.
I got rid of some helpers for creating
TlsConfigout of paths in typesafe configs, because it felt like a weird abstraction (and was only used in unit tests). I'm happy to add them back in.