Skip to content

Allow for private key and certificates to be passed into TlsConfig #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Farhie opened this issue Aug 8, 2018 · 1 comment
Open

Comments

@Farhie
Copy link

Farhie commented Aug 8, 2018

TlsConfig requires that your private key and certificate are on the classpath or a file. For instances where we want self signed certs we are generating them during build time, writing them out to a file and then overriding the config passed into the TlsConfig constructor.

It'd be great if we were able to pass in our self signed cert and key.

@jkinkead
Copy link
Collaborator

This in particular makes TlsConfig very difficult to use; but it also treats all configuration values as required, without providing fallback defaults. This makes it unsuitable for use as a utility outside of the xio toolchain.

What about switching TlsConfig to a builder, instead of an initialize-once bean class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants