optimize 'for' loop: avoid duplicate initialization of variables;

delete code format check: currently not very useful
xiaomx32 · Dec 11, 2024 · 227b633 · 227b633
1 parent d452395
commit 227b633
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 31 deletions.
diff --git a/.github/workflows/code-format-check.yml b/.github/workflows/code-format-check.yml
diff --git a/src/runtime/context.cpp b/src/runtime/context.cpp
@@ -117,6 +117,8 @@ class ContextImpl {
     }
 
     explicit ContextImpl(luisa::string_view program_path) noexcept {
+        using namespace std::string_view_literals;
+
         luisa::filesystem::path program { program_path };
         LUISA_INFO(
             "Created context for program '{}'.",
@@ -137,20 +139,25 @@ class ContextImpl {
             DynamicModule::add_search_path(runtime_directory);
         }
 
+        const auto &extension_so = luisa::filesystem::path(".so");
+        const auto &extension_dll = luisa::filesystem::path(".dll");
+        const auto &extension_dylib = luisa::filesystem::path(".dylib");
+        constexpr std::array possible_prefixes {
+            "lc-backend-"sv,
+            "liblc-backend-"sv // Make Mingw happy
+        };
         for (auto &&p : luisa::filesystem::directory_iterator{runtime_directory}) {
+            auto &&path = p.path();
+            auto p_is_regular_file = p.is_regular_file();
+            const auto &path_extension = path.extension();
+
             if (
-                auto &&path = p.path();
-                p.is_regular_file() && (
-                    path.extension() == luisa::filesystem::path(".so") ||
-                    path.extension() == luisa::filesystem::path(".dll") ||
-                    path.extension() == luisa::filesystem::path(".dylib")
+                p_is_regular_file && (
+                    path_extension == extension_so ||
+                    path_extension == extension_dll ||
+                    path_extension == extension_dylib
                 )
             ) {
-                using namespace std::string_view_literals;
-                constexpr std::array possible_prefixes {
-                    "lc-backend-"sv,
-                    "liblc-backend-"sv // Make Mingw happy
-                };
                 auto filename = luisa::to_string(path.stem());
                 for (auto prefix : possible_prefixes) {
                     if (filename.starts_with(prefix)) {