Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdx is required for non-test as well #59

Closed
wants to merge 1 commit into from
Closed

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Dec 18, 2024

Maybe this is not intentional, but none the less it's the case. Alternatively, the mdx stanza in lib/core/dune should be declared for the test target. I don't remember how to do that off the top of my head.

Maybe this is not intentional, but none the less it's the case.
@xhtmlboi
Copy link
Owner

Thank you very much! I'm quite surprised that mdx isn't with-tested. It's probably changed while trying to publish on OPAM. Is it quickly possible to test locally whether, with these rules, the package passes the OPAM IC?

@reynir
Copy link
Contributor Author

reynir commented Dec 18, 2024

Sorry, I don't understand the question

@xhtmlboi
Copy link
Owner

My bad.
I've never done a release on OPAM, they've been addressed by @dinosaure and @xvw, but I remember @xvw having trouble (because he's as bad at deploying things as I am :D) with the ppx-expect and mdx contexts. So my question is ‘can we quickly validate that with these changes, publishing to OPAM will still work’?

@reynir
Copy link
Contributor Author

reynir commented Dec 18, 2024

Sorry, I think I misunderstood dune's behavior. It is already attached to the runtest alias according to the dune docs https://dune.readthedocs.io/en/stable/reference/dune/mdx.html

I think I got confused because I issued dune build and forgot that builds tests as well. And this "test" is located in lib/core/...

@reynir reynir closed this Dec 18, 2024
@xhtmlboi
Copy link
Owner

I don't understand much about Dune either (and I'd be delighted to have a more digestible tutorial than the documentation).

@reynir reynir deleted the mdx-dep branch December 20, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants