Merge pull request #50 from hannesm/use-digestif-no-cryptokit

yocaml_unix: use digestif for SHA256 computation instead of cryptokit
xhtmlboi · Feb 15, 2024 · 6525183 · 6525183
2 parents b52756b + d36972c
commit 6525183
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,8 @@
+### dev (unreleased)
+
+#### yocaml_unix
+- Use digestif instead of cryptokit (#50 @hannesm, review by @xvw)
+
 ### v1.0.0 2023-11-15 Paris (France)
 
 - First release of YOCaml
diff --git a/lib/yocaml_unix/dune b/lib/yocaml_unix/dune
@@ -1,7 +1,7 @@
 (library
  (name yocaml_unix)
  (public_name yocaml_unix)
- (libraries cryptokit unix yocaml logs cohttp-lwt-unix conduit-lwt))
+ (libraries digestif unix yocaml logs cohttp-lwt-unix conduit-lwt))
 
 (documentation
  (package yocaml_unix))
diff --git a/lib/yocaml_unix/runtime.ml b/lib/yocaml_unix/runtime.ml
@@ -78,8 +78,7 @@ let read_dir path =
 ;;
 
 let hash value =
-  let open Cryptokit in
-  value |> hash_string (Hash.sha256 ()) |> transform_string (Hexa.encode ())
+  Digestif.SHA256.(digest_string value |> to_hex)
 ;;
 
 let content_changes path new_content =

diff --git a/yocaml_unix.opam b/yocaml_unix.opam
@@ -25,7 +25,7 @@ depends: [
   "dune" { >= "2.8" }
   "odoc" {with-doc}
   "preface" { >= "1.0.0" }
-  "cryptokit" { >= "1.16.1" }
+  "digestif"
   "logs" {>= "0.7.0" }
   "conduit-lwt" { >= "4.0.0" }
   "cohttp-lwt-unix" { >= "4.0.0" }