Remove error arg from errorMessageImpl components.

xh · Dec 27, 2024 · a5b88d2 · a5b88d2
1 parent 97d3144
commit a5b88d2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/cmp/error/ErrorMessage.ts b/cmp/error/ErrorMessage.ts
@@ -97,14 +97,12 @@ export const [ErrorMessage, errorMessage] = hoistCmp.withFactory<ErrorMessagePro
             ...rest,
             item: XH.isMobileApp
                 ? mobileErrorMessageImpl({
-                      error,
                       message,
                       title,
                       actionButtonProps,
                       detailsButtonProps
                   })
                 : desktopErrorMessageImpl({
-                      error,
                       message,
                       title,
                       actionButtonProps,

diff --git a/desktop/cmp/error/impl/ErrorMessage.ts b/desktop/cmp/error/impl/ErrorMessage.ts
@@ -17,8 +17,10 @@ import '@xh/hoist/desktop/register';
  * Desktop implementation of ErrorMessage.
  * @internal
  */
-export const errorMessageImpl = hoistCmp.factory<ErrorMessageProps>({
-    render({error, message, title, actionButtonProps, detailsButtonProps}) {
+export const errorMessageImpl = hoistCmp.factory<
+    Omit<ErrorMessageProps, 'error' | 'actionFn' | 'detailsFn'>
+>({
+    render({message, title, actionButtonProps, detailsButtonProps}) {
         let buttons = [],
             buttonBar = null;
         if (detailsButtonProps) buttons.push(detailsButton(detailsButtonProps as ButtonProps));
@@ -31,7 +33,7 @@ export const errorMessageImpl = hoistCmp.factory<ErrorMessageProps>({
 
         return div({
             className: 'xh-error-message__inner',
-            items: [titleCmp({title}), messageCmp({message, error}), buttonBar]
+            items: [titleCmp({title}), messageCmp({message}), buttonBar]
         });
     }
 });

diff --git a/mobile/cmp/error/impl/ErrorMessage.ts b/mobile/cmp/error/impl/ErrorMessage.ts
@@ -17,8 +17,10 @@ import '@xh/hoist/mobile/register';
  * Mobile implementation of ErrorMessage.
  * @internal
  */
-export const errorMessageImpl = hoistCmp.factory<ErrorMessageProps>({
-    render({error, message, title, actionButtonProps, detailsButtonProps}) {
+export const errorMessageImpl = hoistCmp.factory<
+    Omit<ErrorMessageProps, 'error' | 'actionFn' | 'detailsFn'>
+>({
+    render({message, title, actionButtonProps, detailsButtonProps}) {
         let buttons = [],
             buttonBar = null;
         if (detailsButtonProps) buttons.push(detailsButton(detailsButtonProps as ButtonProps));
@@ -31,7 +33,7 @@ export const errorMessageImpl = hoistCmp.factory<ErrorMessageProps>({
 
         return div({
             className: 'xh-error-message__inner',
-            items: [titleCmp({title}), messageCmp({message, error}), buttonBar]
+            items: [titleCmp({title}), messageCmp({message}), buttonBar]
         });
     }
 });