Sort ungrouped items at bottom. (#3872)

* Sort ungrouped items at bottom. * Fix from gsolomon code review
xh · Dec 26, 2024 · 2368d09 · 2368d09
1 parent 06078a2
commit 2368d09
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/cmp/grid/GridModel.ts b/cmp/grid/GridModel.ts
@@ -1771,7 +1771,11 @@ export class GridModel extends HoistModel {
     }
 
     defaultGroupSortFn = (a, b) => {
-        return a < b ? -1 : a > b ? 1 : 0;
+        // Place ungrouped items at bottom.
+        if (a === b) return 0;
+        if (a === '') return 1;
+        if (b === '') return -1;
+        return a.localeCompare(b);
     };
 
     private readonly LEFT_BORDER_CLASS = 'xh-cell--group-border-left';

diff --git a/desktop/cmp/viewmanager/dialog/ManageDialogModel.ts b/desktop/cmp/viewmanager/dialog/ManageDialogModel.ts
@@ -263,12 +263,6 @@ export class ManageDialogModel extends HoistModel {
             sortBy: 'name',
             showGroupRowCounts: false,
             groupBy: ['group'],
-            groupSortFn: (a, b) => {
-                // Place ungrouped items at bottom.
-                if (a == '') return 1;
-                if (b == '') return -1;
-                return a.localeCompare(b);
-            },
             selModel: 'multiple',
             contextMenu: null,
             sizingMode: 'standard',