New ViewService + Fix bug with memory monitoring #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghsolomon
reviewed
Dec 20, 2024
ghsolomon
reviewed
Dec 20, 2024
| } | ||
| return blob | ||
| @Transactional | ||
| JsonBlob createOrUpdate(String type, String name, Map data, String username = username) { |
There was a problem hiding this comment.
Does this work for blobs that are not owned by the authenticated user? In the context of views, blobs describing "Global" views with null owners?
There was a problem hiding this comment.
Here I was definitely mirrorring the create semantics, which only allow you to create a blob that you own. Will comment that better.
There was a problem hiding this comment.
I think I just misunderstood it - looks good to me :)
lbwexler
changed the title
lbwexler
changed the title
|
cr: greg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.