Add LdapConfig to type+doc structure of LdapService soft-config
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a helpful pattern for our non-trivial xh soft-configs, especially ones like this with an internal data structure ( Left as draft because I haven't run the code yet to test. I'm thinking we should sort out how to enable LdapService for Toolbox using our Azure Entra instance - does that make sense to you guys? Is that anything we've already tried as part of overall LdapService development? |
|
Wowzers Seems very promising/helpful. |
|
FYI my intention is still to get this merged. I want to find a good way to test it locally - looking at https://hub.docker.com/r/bitnami/openldap |
lbwexler
approved these changes
Jan 14, 2025
|
I don't think it is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.