fix: remove deprecated edge methods from SimplicialComplex#696
Merged
Conversation
Replace the 5 deprecated methods (add_edge, add_edges_from, add_weighted_edges_from, remove_edge, remove_edges_from) with hard errors pointing users to the simplex equivalents. Previously these issued a UserWarning and delegated silently, which masked API misuse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #696 +/- ##
==========================================
+ Coverage 93.59% 93.77% +0.18%
==========================================
Files 66 66
Lines 5120 5112 -8
==========================================
+ Hits 4792 4794 +2
+ Misses 328 318 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…orts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maximelucas
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimplicialComplex:add_edge,add_edges_from,add_weighted_edges_from,remove_edge,remove_edges_fromUserWarningand silently delegated to the simplex equivalents (add_simplex,add_simplices_from, etc.)XGIErrorwith a message pointing to the correct methodSince
SimplicialComplexinherits fromHypergraph, these methods must be explicitly overridden — otherwise the parent'sadd_edgewould be exposed, which would add edges without simplicial closure.Note:
read_json/write_jsondeprecation is tracked separately in #697.Test plan
SimplicialComplex🤖 Generated with Claude Code