Open
Conversation
scipy's diags_array now warns (FutureWarning) when int64 input is silently cast to float64 output, and will change this behavior in a future release. This would silently alter numerical results. Ensure degree and weight arrays are explicitly float before passing to diags_array in both laplacian() and normalized_hypergraph_laplacian(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 66 66
Lines 5123 5124 +1
=======================================
+ Hits 4795 4796 +1
Misses 328 328 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pandas now uses dtype='str' instead of dtype='object' for string Index columns. Update the expected doctest output in IDStat.name accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
leotrs
force-pushed
the
fix-scipy-diags-warning
branch
from
d5c662d to
d8fbf76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FutureWarningfrom scipy'sdiags_arrayabout implicit int-to-float dtype castingfloatbefore passing todiags_arrayinlaplacian_matrix.pyfloat(notint) in weighted laplacian computationContext
scipy >= 1.14 warns when
diags_arrayreceives integer data without an explicit dtype, since a future version will preserve integer dtype instead of casting to float. Our laplacian code relies on float arithmetic, so we now cast explicitly.Test plan
FutureWarningfrom scipydiags_array🤖 Generated with Claude Code